add promise_batch_action_function_call_weight #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not really; it's just tested very specifically within nearcore and then through workspaces tests in examples |
|
@austinabell Got it. Sounds good! @volovyks this one is ready for review. Testing gas=0, weight=1 in the test pass remaining to the cross contract call. Rust SDK cross contract call, factorial example has used this feature, I can add the similar example in high level promise api work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #175
@austinabell do you have a good use case to test promise_batch_action_function_call_weight? Didn't see
sys::promise_batch_action_function_call_weightis tested in Rust SDK